Suggesting improvements to code is certainly within the realm of what Mark can do, but the change file needs to come from the person who originally posted it. I certainly don’t want to deal with version/author confusion.
Many of us have posted potential changes to the code as “hacks” but we don’t redistribute other people’s code.
Inside the original code:
THIS IS COPYRIGHTED SOFTWARE All RIGHTS RESERVED Written by: Travis Smith Copyright (c) 2006 Hop Studios http://www.hopstudios.com/ -------------------------------------------------------- Please do not distribute this extension without written consent from the author.
Added: Hopefully Travis will be able to take the changes Mark suggested, and add a newer version for us to use.
Mark, we really do appreciate your work on the extensions you’ve done. Thanks in advance for working with Travis to get an improved version of his extension out there.
Sue, i’m aware of software licensing too, being an IT professional myself, and i know that publicly posted doesn’t mean GPL’d. It was your TONE i thought was uncalled for, mostly, and that i was trying (perhaps badly) to call attention to. Mark was trying to be helpful, and is in general HUGELY helpful, and i thought you were rude.
However, you’re a Big Name EE Person and i’m a peon, so what do i know?
One’s name matters little here, their opinion and knowledge is where the weight is. I actually found Sue’s post(s) about this honest and not rude. She merely posted a question and information about the license. Not sure there was any real tone there, alienne.
Just so everyone’s clear—I think it’s nice that Mark wanted to be helpful and improve my extension, and we’ve chatted offline.
While I’d been meaning to update the extension anyway, I hadn’t planned to do so today. But seeing as there’s a bit of interest, I’ve upgraded it to version 1.1—see the first post in this thread for the latest file. In this version, I…
* added link on CP home page that lets users edit that home page
* added settings for each individual modification
* added a language file
* added version notes
* fixed it so that it integrates better with other extensions
Version 1.1 is still free, but as Sue notes, I do still want to keep the copyright.
I’m sorry i snarked at you—it was uncalled for. I was having a really bad day yesterday, and i blew the whole incident WAY out of proportion. Thanks for being more of a grownup than i was being. *wry grin*
Nice extension. My feedback is that I’d like to see additional options to hide the “Preview” button and the “File Upload” button. Here’s two scenerios where this would be helpful:
1) Normally I have a lot of miscellanious custom fields on a publish page or have styled the output content in the actual web page in such a way that the “Preview” really is meaningless for the viewer (a big jumble of content that doesn’t show how the content and images will work on the actual page). I’m also using an extension that adds links to view the entry directly from the control panel as well as when saving the entry so the user has the option to preview (if saved as draft) the content as it will appear in the actual web page so the default preview button is needless.
2) I’ve got Mark’s custom field file uploader extension and the File Manager extension and the default file manager on the publish form it isn’t used at all.
Having these two additional options to hide those buttons would be nice so that one could control exactly which of the “Preview,” “Quick Save,” and “File Upload” would show up depending on the project specs and other extensions that are used to handle that functionality.
This looks like a very extension, but unfortunately it doesn’t work exactly right for me.
The upload bit and the CP Home bit work just fine, though I would suggest adding a settings field to change the text of the upload link.
The Quick Save part is where I run into problems. For one, it doesn’t do anything. For another, you should change the settings language to remove subjectivity such as “baffling.” I don’t find the Quick Save button baffling at all, nor do any of the writers on my site. Also, I suggest removing the word “indecipherable” or changing it to something less subjective, like “obscure.”
I’d also like to have more control over which buttons are visible and what language they use, like Rob Q. I never use the Submit button, so I’d like to be able to hide that, and I’d like to be able to change the Quick Save button’s text to something else like Save or Update (but something I can choose).
At any rate, keep up the good work. I’m looking forward to 1.2.
Ok, here’s two more additional requests for functionality (adding to my post above in this thread) I would also like to see in a pie in the sky world:
1) Combine Mark Huot’s “Duplicate” extension (adds “Duplicate” button in same publish page area) with PPI Ext so that it is another bulleted option with the others, and
2) Be able to apply these individual setttings on a per weblog basis.
So, version 1.2 has arrived. This has a bug fix and addresses another two of my pet peeves:
* added ability to insert a tab in the text field of the template screen
* added a “Save As New Copy” checkbox
* fixed a bug where if you preview, the boxes revert to the EE default
I haven’t ignored your other feedback. I’ll address some of it here, and work on the rest of it as I can. Arden,
* I don’t think it’s wrong to call quick save baffling; I have never had a client be NOT baffled by it.
* If you’d rather keep the Quick Save button, just change the language file to call the “Save” button “Quick Save” and then hide the real “Quick Save” button. Yes, that means you’re still doing a full submit, but that’s not the end of the world in most cases.
* Ditto for changing the language of the control panel page text.
I’m probably not going to add features that are opposites: I won’t add something that hides the real save button, for example, because then I have to add logic that deals with what happens when you hide both buttons and now you can’t save at all. Well, I guess I could let people make their own messes… Hmmm. It would take a rewrite of the way I look for what to change… Hmmm.
As for applying it on a per-weblog basis, again, that makes it really complicated in the settings department, and I probably won’t go there.
Hiding the upload link entirely, that seems doable. Watch this space....
I don’t think it’s wrong to call quick save baffling; I have never had a client be NOT baffled by it.
Either way, it’s a matter of opinion as to whether or not it is “baffling,” and does not belong in the description of the Quick Save button. Control panel preferences are not the place to give your opinion on the usefulness or confusingness of a feature because it’s really not your call once you’ve released the extension.
I, for one, find the Quick Save button quite useful because I can save my progress and not have to navigate back a page to continue editing, much like the Save function of most document-based applications. It seems that your clients aren’t the brightest bunch if they can’t figure that out, but that’s just my opinion — which is the whole point, it’s your opinion vs. my opinion on how useful it is, so you shouldn’t pass judgment in the first place. At least not in the extension itself. You can argue on here all you want and that’s your right, but subjective language does not belong in an objective context.
Anyway, this is all kind of off-topic. I’ll be downloading and playing with the extension as soon as I post this, so thank you in advance.
Very cool! Thanks! If you have an opportunity it would be great to have the option to disable the preview button too - just a reminder. Thanks, I’m going to check this out now.
update: just checked it out and pretty cool. Noticed that the direct edit button is not showing up on the CP homepage for me?
I really like the save as new feature. Thank you for adding that!
Updated. You can now customize and/or remove any of the buttons on the publish form. But don’t remove them all. That’s just silly.
Go back to the first message to download the current version.
1.5 - Jan. 2, 2007
=======
* rewrote it to use fewer hooks, and a different method of showing/hiding buttons
* Added settings to allow folks to change the text on Preview/Quick Save/Save buttons, and next to the File Upload button
* I didn’t make the File Upload box itself disappear for two reasons. 1) It would have looked unbalanced, and 2) it was too hard.
* Added link next to URL Title to preview the entry on the live site. This relies on the “search results” base URL for that entry’s weblog
* built using EE 1.5.2 (20061128)
Very nice - love all the options - especially the ability to rename buttons, etc. Thanks! Quick question: Where would this link show up when enabled: Publish: Add a handy link to view the entry on the live site?
